Val Bancer

Results 35 comments of Val Bancer

> ... because each domain == separate package instance... Sounds like this might work. > That would require custom message loading, which you can do inside your custom package class....

One point that have not been mentioned: when I will switch to gettext implementation I would expect `cake i18n` shell still work and generate pot files into gettext compatible paths...

> ... generate pot files into gettext compatible paths like "src/Locale/de_DE/LC_MESSAGES". My bad. POT files are not locale dependent. I meant "src/Locale" as it is now.

> Or are current ways enough? Not enough in my opinion. A way to configure the paths to po files is not available.

Yes, it is very annoying that pcov does not take into account `` paths from phpunit configuration file. The same problem in details is described here - https://stackoverflow.com/questions/68688566/why-is-phpunit-pcov-not-generating-code-coverage-stats.

Some PHP frameworks include files without PHP classes such as ones where PHP is mixed with HTML. The coverage is generated well without `@covers` annotation when testing a controller class....

By the way, unit tests fail on 4.x branch with a similar error: ``` git checkout 4.x vendor/bin/phpunit ./tests/ PHPUnit 9.6.19 by Sebastian Bergmann and contributors. E..................... 22 / 22...

Right, this makes it impossible to call `use LoggerAwareTrait;`. I can implement LoggerAwareTrait of course but having `$this->logger` an instance of LoggerInterface in hundreds of files where LoggerAwareTrait is used...

Yes, we will switch to ErrorTrap and ExceptionTrap when we are ready to upgrade to 4.5.

Could you make a pull request to 3.x branch instead?