react-native-make icon indicating copy to clipboard operation
react-native-make copied to clipboard

Android - running set-icon removes the application tag

Open rares-lupascu opened this issue 6 years ago • 4 comments

react-native set-icon --platform android --path ./assets/app-icon-android-transparent.png

thes start application tag from AndroidManifest disappears

rares-lupascu avatar Sep 23 '19 13:09 rares-lupascu

anyone?

rares-lupascu avatar Sep 25 '19 15:09 rares-lupascu

Hello, I will be looking into the issue, could you please give me an example the generated manifest versus the expected manifest?

yleflour avatar Oct 14 '19 11:10 yleflour

I got the same issue. It removes start tag. Also, all ic_launcher**_round**.png are still set as the default android icon. image

Using "@bam.tech/react-native-make": "^3.0.0"

Any suggestions, please?

htduy262 avatar May 12 '20 08:05 htduy262

@rares-lupascu the problem with me was that my AndroidManifest.xml file wasn't formatted in a way that react-native set-icon can handle. Every property of the tag should be on a new line like that for example:

  <application
    android:name=".MainApplication"
    android:label="@string/app_name"
    android:icon="@mipmap/ic_launcher"
    android:launchMode="singleTop"
    android:allowBackup="false"
    android:theme="@style/AppTheme">

Otherwise the tag gets removed for some reason.

thinklinux avatar May 27 '20 13:05 thinklinux