react-native-image-resizer icon indicating copy to clipboard operation
react-native-image-resizer copied to clipboard

Changes needed for gradle 3.0.1 compatibility

Open pacamara opened this issue 7 years ago • 2 comments

Some minor changes are needed for gradle 3.0.1 compatibility: in android/build.gradle:

  • Remove the buildToolsVersion, gradle now specifies a default and the current value conflicts with that.
  • Declare dependencies using api not compile per https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html#new_configurations

We are currently hacking these changes with a script in status.im, and would rather it is fixed upstream. Thanks!

Parent issue: https://github.com/status-im/status-react/issues/3037

pacamara avatar Jan 19 '18 14:01 pacamara

Thanks for opening the issue :) Is there any change that this could break compilation of Gradle version 2.x? It seems that api is only supported since Gradle 3?

4ian avatar Jan 23 '18 19:01 4ian

Yes, it turns out to be a breaking change for apps authored with react-native init, requiring manual changes to the generated code to fix. Please see discussion at https://github.com/react-native-community/react-native-svg/issues/581#issuecomment-359192907 A solution could be to provide a separate gradle 3 tag?

pacamara avatar Jan 24 '18 10:01 pacamara

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 01 '22 21:09 stale[bot]

This issue has been automatically closed. Thank you for your contributions.

stale[bot] avatar Sep 09 '22 03:09 stale[bot]