generator-rn-toolbox
generator-rn-toolbox copied to clipboard
feat(generators): Added generation ic_launcher_round.png in assets icon
Hi, thanks for submitting a Pull Request! :balloon:
Before submitting, please be sure to check a few things:
Commit names formatting
This repository is automatically published to npm with semantic-release.
In order to manage that, your commit should follow the AngularJS commit conventions as explained here
You can use yarn commit
to write a commit respecting this convention.
Just tested it, and it worked 👍
Thanks for the PR. I've tried it with one of my projects but it seems like some of the rounded icons have a white strip at some of their edges, despite the background being navy in the original square icon. Sometimes they have this at top, bottom, left, and right all together, and sometimes a combination of these.
Thank you for your answer. I guess it's all about the margin of 90% I added to get the icon center in a smaller square. I use a mask and rewrite the icon on it with the compose "copyopacity". I didn't experience the bug you describe, I will try with different icon size, transparency and format. For the moment I still don't know how to prevent that except remove the margin.
Hello dear.
When do you plan to release this feature?
Best regards
Fantastic job. I've tested it in my project and it works well. 👍
I've also added some comments to pull review commit's code - there is one potential problem with async writing of mask file and using it for composing opacity.
I think this PR should be merged and ic_launcher_round
should be supported because starting from react native 0.58.0 android:roundIcon="@mipmap/ic_launcher_round"
is used in React Native init
project template (https://github.com/react-native-community/rn-diff-purge/compare/version/0.57.0...version/0.58.0).
Works great on react native 0.59.4 Thanks!
Maybe one more approving review?
Works great, although it looks like Android 10 is pushing squircle
icons.
Works great, although it looks like Android 10 is pushing
squircle
icons.
Oh I was not aware of that. I think you are right. Need to be done as squircle icons.
I'm looking at this for the splash as well -> https://developer.android.com/preview/features/darktheme
The default generated splash background color on a transparent PNG is #00000000
which renders as black
on both light and dark mode.
Update: Manually setting splashBackground
to #FFFFFF00
renders yellow. I need to investigate how colors work in colors.xml
.
now must be merging :(
Could you please merge this PR