generator-rn-toolbox feat(generators): Added generation ic_launcher

feat(generators): Added generation ic_launcher_round.png in assets icon

Open vdelacou opened this issue 5 years ago • 12 comments

Hi, thanks for submitting a Pull Request! :balloon:

Before submitting, please be sure to check a few things:

Commit names formatting

This repository is automatically published to npm with semantic-release.

In order to manage that, your commit should follow the AngularJS commit conventions as explained here

You can use yarn commit to write a commit respecting this convention.

Mar 18 '19 07:03 vdelacou

Just tested it, and it worked 👍

Mar 22 '19 09:03 schumannd

Thanks for the PR. I've tried it with one of my projects but it seems like some of the rounded icons have a white strip at some of their edges, despite the background being navy in the original square icon. Sometimes they have this at top, bottom, left, and right all together, and sometimes a combination of these.

Mar 28 '19 15:03 ghost

Thank you for your answer. I guess it's all about the margin of 90% I added to get the icon center in a smaller square. I use a mask and rewrite the icon on it with the compose "copyopacity". I didn't experience the bug you describe, I will try with different icon size, transparency and format. For the moment I still don't know how to prevent that except remove the margin.

Mar 31 '19 03:03 vdelacou

Hello dear.

When do you plan to release this feature?

Best regards

Apr 05 '19 15:04 dldinza-web

Fantastic job. I've tested it in my project and it works well. 👍

I've also added some comments to pull review commit's code - there is one potential problem with async writing of mask file and using it for composing opacity.

I think this PR should be merged and ic_launcher_round should be supported because starting from react native 0.58.0 android:roundIcon="@mipmap/ic_launcher_round" is used in React Native init project template (https://github.com/react-native-community/rn-diff-purge/compare/version/0.57.0...version/0.58.0).