generator-rn-toolbox icon indicating copy to clipboard operation
generator-rn-toolbox copied to clipboard

Fix flow for Page optional props (base template)

Open AuroreM opened this issue 6 years ago • 4 comments

PR related to this issue https://github.com/bamlab/generator-rn-toolbox/issues/149

AuroreM avatar Nov 26 '17 22:11 AuroreM

@Almouro What is the best practise for the commits name? Is there documentation/some hint about this somewhere? ;)

4ian avatar Nov 28 '17 10:11 4ian

Yes, here but it's not really clear enough. It would be better to have this in the pull request template :) I'm going to add this right now.

But yeah, @AuroreM, your commit should be starting with fix:

Almouro avatar Nov 28 '17 13:11 Almouro

Or maybe activate back Squash and merge so that you can rename directly (no rework)?

Minishlink avatar Nov 28 '17 13:11 Minishlink

@AuroreM : ping

tychota avatar Jan 04 '18 09:01 tychota