bambi icon indicating copy to clipboard operation
bambi copied to clipboard

Sampler parameters not used when calling JAX samplers

Open GStechschulte opened this issue 9 months ago • 1 comments

To change bayeux based sampler parameter values, we require passing kwargs like

kwargs = {
        "adapt.run": {"num_steps": 500},
        "num_chains": 4,
        "num_draws": 250,
        "num_adapt_draws": 250
}

blackjax_nuts_idata = model.fit(inference_method="blackjax_nuts", **kwargs)

However, if a user attempts to also pass draws and tune

kwargs = {
        "adapt.run": {"num_steps": 500},
        "num_chains": 4,
        "num_draws": 500,
        "num_adapt_draws": 500
}

blackjax_nuts_idata = model.fit(draws=250, tune=250, inference_method="blackjax_nuts", **kwargs)

the values for draws and tune are never used. Should we print to stdout that these values are not used? Or using some other means to make the user aware?

Of course, after sampling one can infer the number of chains, draws, etc. Just a thought.

GStechschulte avatar May 27 '24 12:05 GStechschulte