databag icon indicating copy to clipboard operation
databag copied to clipboard

F-Droid build failed

Open linsui opened this issue 1 year ago • 10 comments

Firebase is non-free. Is it used for Android?

linsui avatar May 11 '24 09:05 linsui

I use it only in the android build, I must have made an error in my merge of common features. I will look now

balzack avatar May 11 '24 14:05 balzack

@linui, i think i accidentally tagged my android branch in the release instead of the fdroid branch.

I am sorry for the trouble, the latest release now is tagged from the fdroid branch.

balzack avatar May 11 '24 14:05 balzack

@balzack I'm testing https://github.com/balzack/databag/releases/tag/V1.1.13b now

but not sure how to proceed with autoupdates as the previous (broken one) Tag versionCode is waaaay higher and checkupdate will just say there's no newer one https://github.com/balzack/databag/blob/v1.1.13/app/mobile/android/app/build.gradle#L107

eg. maybe tag the fdroid versions differently -fdroid or next version bring fdroid versioncode at the same value?

licaon-kter avatar May 13 '24 17:05 licaon-kter

Could I increment the minor number to resolve this? (1.2)

With android I use the version code as a build number, which is why they are so different.

balzack avatar May 13 '24 17:05 balzack

I guess it would actually have to be (1.6) if that solution seems appropriate.

balzack avatar May 13 '24 17:05 balzack

Could I increment the minor number to resolve this? (1.2)

it's not about versionName, that can be anything even foobar

With android I use the version code as a build number, which is why they are so different.

Android cares about versionCode and so is F-Droid

licaon-kter avatar May 14 '24 07:05 licaon-kter

updated recipe but disabled autoupdates for now, until we can pickup the right version

https://gitlab.com/fdroid/fdroiddata/-/commit/92e7116da4798ade518ee0b2d49a0d272462007b

licaon-kter avatar May 14 '24 07:05 licaon-kter

I am happy to bump the version code way higher to match android, if that is what you recommend.

For some (wrong) reason, I thought a large versionCode should be avoided, ie. "Version 1.1 (1081004)"

Thanks again for your support, I'm sorry for the trouble.

balzack avatar May 15 '24 19:05 balzack

I see the pipeline build failed, but it seems related to downloading the ndk, and the build works locally. Please let me know if there is something for me to resolve.

balzack avatar May 15 '24 19:05 balzack

no, https://gitlab.com/fdroid/fdroiddata/-/jobs/6844374274/artifacts/browse/tmp/ means 3 arches were built, it's just the CI having it's storage filled :)

licaon-kter avatar May 16 '24 15:05 licaon-kter

The versionCode has been updated to 1019 in the next release to resolve my previous error. Can auto-updates be re-enabled?

balzack avatar May 26 '24 17:05 balzack

Ok, so thee new versionCodes will be 1019001..1019004, yes?

licaon-kter avatar May 27 '24 15:05 licaon-kter

yes, I think that is correct. The value in the build.gradle files is 1019, which will produce 1019001..1019004. thank you!

balzack avatar May 27 '24 15:05 balzack

nice https://gitlab.com/fdroid/fdroiddata/-/commit/9b18dd7601237ba67fa9b01dc918cfd56e0d0cb1

licaon-kter avatar May 27 '24 15:05 licaon-kter

thanks for your support...you are awesome!

balzack avatar May 27 '24 16:05 balzack

/close this

licaon-kter avatar May 27 '24 16:05 licaon-kter