spyke icon indicating copy to clipboard operation
spyke copied to clipboard

Enable params on DELETE via config

Open victoreduardoss opened this issue 1 year ago • 2 comments

What

Allow custom params on DELETE via config.

Why

The https://github.com/balvig/spyke/pull/157 reverted the possibility of passing params on DELETE action. However, our app uses shard databases and requires some extra params to identify which shard will be hit. In this change, we allow custom params on DELETE via config.

victoreduardoss avatar May 03 '24 20:05 victoreduardoss

hey @balvig, could you review and consider this change 🥺

victoreduardoss avatar May 03 '24 20:05 victoreduardoss

You can still use url params like so: DeleteBranch.request(:delete, 'projects/projectname/repos/reponame/branches?name=asd')

keithxm23 avatar Jun 13 '24 20:06 keithxm23