ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

[Master] Change the name of the new json option

Open mindula opened this issue 1 year ago • 3 comments

Purpose

title.

Fixes #<Issue Number>

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • [ ] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [ ] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

mindula avatar Apr 18 '24 10:04 mindula

Why do we need this PR if the same changes are being sent to the master with this commit? https://github.com/ballerina-platform/ballerina-lang/pull/42589/commits/5cce3abdda94cd2af866b2df315c07124ab77d76 (of the PR https://github.com/ballerina-platform/ballerina-lang/pull/42589)

nipunayf avatar Apr 18 '24 13:04 nipunayf

Why do we need this PR if the same changes are being sent to the master with this commit? 5cce3ab (of the PR #42589)

Wont be sending this PR. I removed the commit that changed the name from this. Will update it later.

mindula avatar Apr 18 '24 13:04 mindula

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar May 03 '24 19:05 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar May 20 '24 19:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.28%. Comparing base (fd608ba) to head (1b88b88). Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42594      +/-   ##
============================================
- Coverage     77.28%   77.28%   -0.01%     
+ Complexity    51326    51324       -2     
============================================
  Files          2929     2929              
  Lines        204428   204426       -2     
  Branches      26671    26671              
============================================
- Hits         157994   157986       -8     
- Misses        37846    37852       +6     
  Partials       8588     8588              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 03 '24 07:06 codecov[bot]