ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Fix invalid subtyping relationship in xml

Open poorna2152 opened this issue 1 year ago • 10 comments

Purpose

Fixes #34779

Approach

Update isAssignable to not to allow assigning of value with static typexml to value with static type xml:Comment|xml:Element|xml:ProcessingInstruction|xml:Text. But this assignment is allowed in the type binding pattern in theforeach loops. Thus in order to handle this case new function is introduced constituentTypesAssignable.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • [ ] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [ ] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

poorna2152 avatar Feb 26 '24 05:02 poorna2152

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.35%. Comparing base (6399eae) to head (310444d). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...llerinalang/compiler/semantics/analyzer/Types.java 88.88% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42221      +/-   ##
============================================
- Coverage     77.37%   77.35%   -0.02%     
+ Complexity    58593    58587       -6     
============================================
  Files          3460     3460              
  Lines        220095   220095              
  Branches      28912    28910       -2     
============================================
- Hits         170295   170264      -31     
- Misses        40382    40412      +30     
- Partials       9418     9419       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 27 '24 12:02 codecov[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Mar 16 '24 19:03 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Apr 03 '24 19:04 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Apr 24 '24 19:04 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar May 10 '24 19:05 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jun 06 '24 19:06 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jun 27 '24 19:06 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jul 23 '24 19:07 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Aug 14 '24 19:08 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Aug 30 '24 19:08 github-actions[bot]