ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Remove `typedesc` class for records

Open chiranSachintha opened this issue 1 year ago • 13 comments

Purpose

$title.

Fixes #41851

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [ ] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

chiranSachintha avatar Dec 09 '23 09:12 chiranSachintha

@chiranSachintha, this will require changes since we decided to have a record typedesc class, right? Shall we close this and reopen once it is ready to be reviewed?

MaryamZi avatar Dec 22 '23 06:12 MaryamZi

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jan 06 '24 19:01 github-actions[bot]

@chiranSachintha, this will require changes since we decided to have a record typedesc class, right? Shall we close this and reopen once it is ready to be reviewed?

What we discussed is to introducing default values to map within the type description (typedesc), aligning with the approach used in the previous implementation, and remove the separate classes generated for the typedesc of records. Therefore, this fix is required to implement those changes.

chiranSachintha avatar Jan 08 '24 04:01 chiranSachintha

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jan 23 '24 19:01 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Jan 26 '24 19:01 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Feb 23 '24 19:02 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Feb 27 '24 19:02 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Mar 17 '24 19:03 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Apr 05 '24 19:04 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Apr 08 '24 19:04 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jun 14 '24 19:06 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Jun 18 '24 19:06 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jul 04 '24 19:07 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Jul 07 '24 19:07 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Jul 30 '24 19:07 github-actions[bot]

Closed PR due to inactivity for more than 18 days.

github-actions[bot] avatar Aug 03 '24 19:08 github-actions[bot]

Closing this PR since if we remove the typedesc class we need to find a way to preserve the value class for the corresponding typedesc. Hence we decided to keep the class as it is

rdulmina avatar Aug 22 '24 07:08 rdulmina