ballerina-lang
ballerina-lang copied to clipboard
Create symbols for resource path segments
Purpose
$title
Fixes #37604
Check List
- [x] Read the Contributing Guide
- [ ] Updated Change Log
- [ ] Checked Tooling Support (#<Issue Number>)
- [ ] Added necessary tests
- [ ] Unit Tests
- [ ] Spec Conformance Tests
- [ ] Integration Tests
- [ ] Ballerina By Example Tests
- [ ] Increased Test Coverage
- [ ] Added necessary documentation
- [ ] API documentation
- [ ] Module documentation in Module.md files
- [ ] Ballerina By Examples
Codecov Report
Base: 76.63% // Head: 76.34% // Decreases project coverage by -0.29%
:warning:
Coverage data is based on head (
4567ed4
) compared to base (a0551a0
). Patch coverage: 87.91% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## 2201.3.0-stage #38163 +/- ##
====================================================
- Coverage 76.63% 76.34% -0.30%
- Complexity 53045 53118 +73
====================================================
Files 3354 3390 +36
Lines 199136 200365 +1229
Branches 25834 25998 +164
====================================================
+ Hits 152605 152965 +360
- Misses 37859 38724 +865
- Partials 8672 8676 +4
Impacted Files | Coverage Δ | |
---|---|---|
...symbols/resourcepath/BallerinaPathSegmentList.java | 100.00% <ø> (ø) |
|
...wso2/ballerinalang/compiler/bir/model/BIRNode.java | 85.23% <ø> (ø) |
|
...alang/compiler/desugar/DeclarativeAuthDesugar.java | 23.80% <ø> (+0.63%) |
:arrow_up: |
...compiler/semantics/analyzer/IsolationAnalyzer.java | 84.88% <ø> (+0.01%) |
:arrow_up: |
...compiler/semantics/analyzer/TypeParamAnalyzer.java | 85.94% <0.00%> (+0.07%) |
:arrow_up: |
...compiler/semantics/model/symbols/BClassSymbol.java | 80.00% <ø> (ø) |
|
...iler/semantics/model/symbols/BErrorTypeSymbol.java | 100.00% <ø> (ø) |
|
...iler/semantics/model/symbols/BInvokableSymbol.java | 89.47% <ø> (ø) |
|
.../semantics/model/symbols/BInvokableTypeSymbol.java | 100.00% <ø> (ø) |
|
...g/compiler/semantics/model/symbols/BLetSymbol.java | 100.00% <ø> (ø) |
|
... and 189 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Will fix the build. Can start reviewing
When looking at the path-symbols of the target-func, we get symbols (BResourcePathSegmentSymbol
). Here, symbol-kinf information is missing.
We want to distinguish between path symbols between
- Rest param
- path param
- identifier segment
@rdulmina What do we need to do here?
When looking at the path-symbols of the target-func, we get symbols (
BResourcePathSegmentSymbol
). Here, symbol-kinf information is missing.We want to distinguish between path symbols between
* Rest param * path param * identifier segment
@rdulmina What do we need to do here?
@gimantha @KavinduZoysa should we create symTags for each kind? Currently we have only one kind for 3 of them

Kind is always `null` in `BResourcePathSegmentSymbol`. Is this intentional?
No, will add kinds
We need to send this changes to master as well