ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Reuse fail node without creating new blocks for same on-fail clause

Open gabilang opened this issue 2 years ago • 1 comments

Purpose

$title

Fixes #37842

Approach

Reuse fail nodes created at desugar for the same on-fail clause.

Samples

Remarks

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

gabilang avatar Oct 07 '22 05:10 gabilang

Codecov Report

Base: 80.21% // Head: 76.31% // Decreases project coverage by -3.90% :warning:

Coverage data is based on head (de53b66) compared to base (9715f15). Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38114      +/-   ##
============================================
- Coverage     80.21%   76.31%   -3.91%     
+ Complexity    79744    53077   -26667     
============================================
  Files          3541     3393     -148     
  Lines        289752   199728   -90024     
  Branches      56496    25764   -30732     
============================================
- Hits         232432   152426   -80006     
+ Misses        48452    38767    -9685     
+ Partials       8868     8535     -333     
Impacted Files Coverage Δ
...java/io/ballerina/runtime/api/utils/TypeUtils.java 17.50% <0.00%> (-8.00%) :arrow_down:
...nalang/compiler/bir/codegen/JvmInstructionGen.java 89.74% <ø> (-5.48%) :arrow_down:
...g/debugadapter/evaluation/utils/VariableUtils.java 40.74% <ø> (-15.40%) :arrow_down:
...pter/evaluation/engine/InvocationArgProcessor.java 73.33% <37.50%> (+10.97%) :arrow_up:
...apter/evaluation/engine/NodeBasedArgProcessor.java 35.08% <50.00%> (ø)
...debugadapter/evaluation/utils/EvaluationUtils.java 69.12% <65.51%> (-7.23%) :arrow_down:
...ne/expression/QualifiedNameReferenceEvaluator.java 74.54% <77.77%> (+9.42%) :arrow_up:
...xpression/BuiltinSimpleNameReferenceEvaluator.java 86.66% <86.66%> (ø)
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 90.33% <87.80%> (-5.73%) :arrow_down:
...va/org/wso2/ballerinalang/compiler/bir/BIRGen.java 92.40% <98.43%> (-4.64%) :arrow_down:
... and 922 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 11 '22 15:10 codecov[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Nov 04 '22 19:11 github-actions[bot]

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions[bot] avatar Dec 01 '22 20:12 github-actions[bot]