ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Optimize BIR by reusing temporary variables created for observability instrumentation

Open gabilang opened this issue 2 years ago • 1 comments

Purpose

$title

Fixes #37506

Approach

Reuse possible temporary variables without creating new variables each time for observability instrumentation.

Samples

Remarks

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

gabilang avatar Sep 07 '22 03:09 gabilang

Codecov Report

Base: 76.67% // Head: 76.68% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (826c037) compared to base (8b9e0b9). Patch coverage: 91.21% of modified lines in pull request are covered.

:exclamation: Current head 826c037 differs from pull request most recent head 30d62bc. Consider uploading reports for the commit 30d62bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #37659   +/-   ##
=========================================
  Coverage     76.67%   76.68%           
- Complexity    53120    53145   +25     
=========================================
  Files          3355     3357    +2     
  Lines        199345   199429   +84     
  Branches      25874    25880    +6     
=========================================
+ Hits         152857   152935   +78     
- Misses        37818    37827    +9     
+ Partials       8670     8667    -3     
Impacted Files Coverage Δ
...ompiler/bir/codegen/interop/ExternalMethodGen.java 33.70% <0.00%> (ø)
...g/compiler/bir/codegen/interop/JavaMethodCall.java 0.00% <0.00%> (ø)
...lang/compiler/bir/codegen/interop/JTerminator.java 40.00% <40.00%> (ø)
...inalang/compiler/bir/codegen/JvmTerminatorGen.java 84.43% <66.66%> (+0.14%) :arrow_up:
...er/bir/codegen/interop/JMethodCallInstruction.java 75.00% <75.00%> (ø)
...nalang/compiler/bir/codegen/JvmInstructionGen.java 89.81% <85.00%> (-0.01%) :arrow_down:
...lang/compiler/bir/codegen/JvmObservabilityGen.java 96.31% <100.00%> (-0.03%) :arrow_down:
...ompiler/bir/codegen/interop/JIConstructorCall.java 50.00% <100.00%> (+10.00%) :arrow_up:
...ang/compiler/bir/codegen/interop/JIMethodCall.java 50.00% <100.00%> (+10.00%) :arrow_up:
...nalang/compiler/bir/codegen/interop/JTermKind.java 87.50% <100.00%> (+87.50%) :arrow_up:
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 07 '22 08:09 codecov[bot]