ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

[2201.2.x] Implement change sub type of raw template code action

Open LakshanWeerasinghe opened this issue 2 years ago • 1 comments

Purpose

This CA will use to resolve diagnostic for the code BCE3936.

Fixes #34409

Master PR #38242

Samples

https://user-images.githubusercontent.com/46857198/187604408-22eaa49f-7c10-48a0-b407-122c2bdc5e32.mov

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [x] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [x] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

LakshanWeerasinghe avatar Aug 31 '22 05:08 LakshanWeerasinghe

Codecov Report

Base: 72.13% // Head: 74.69% // Increases project coverage by +2.55% :tada:

Coverage data is based on head (3ceaaea) compared to base (ad9fa98). Patch coverage: 79.85% of modified lines in pull request are covered.

:exclamation: Current head 3ceaaea differs from pull request most recent head c582e3b. Consider uploading reports for the commit c582e3b to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.2.x   #37588      +/-   ##
==============================================
+ Coverage       72.13%   74.69%   +2.55%     
- Complexity      49085    50173    +1088     
==============================================
  Files            3353     3339      -14     
  Lines          195144   193537    -1607     
  Branches        25602    25313     -289     
==============================================
+ Hits           140772   144556    +3784     
+ Misses          46418    40627    -5791     
- Partials         7954     8354     +400     
Impacted Files Coverage Δ
...langserver/codeaction/CodeActionNodeValidator.java 24.44% <0.00%> (-3.73%) :arrow_down:
.../langserver/common/constants/CommandConstants.java 90.00% <ø> (ø)
...ers/context/RemoteMethodCallActionNodeContext.java 80.48% <50.00%> (ø)
...rver/codeaction/CodeActionContextTypeResolver.java 67.30% <65.71%> (-3.29%) :arrow_down:
...lang/langserver/common/utils/TypeResolverUtil.java 82.71% <83.33%> (-2.71%) :arrow_down:
...getype/ConvertToXmlOrStringTemplateCodeAction.java 87.09% <87.09%> (ø)
...ngserver/completions/util/ContextTypeResolver.java 73.11% <91.30%> (-0.53%) :arrow_down:
...oviders/context/InvocationNodeContextProvider.java 84.72% <100.00%> (+0.43%) :arrow_up:
.../workspace/BallerinaWorkspaceManagerProxyImpl.java 61.22% <0.00%> (-20.41%) :arrow_down:
...org/ballerinalang/docgen/generator/model/Type.java 72.65% <0.00%> (-11.00%) :arrow_down:
... and 368 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 31 '22 10:08 codecov[bot]

Shall we send this to 2201.3.x instead?

IMS94 avatar Oct 21 '22 10:10 IMS94

Shall we send this to 2201.3.x instead?

+1 to 2201.3.x and master

malinthar avatar Oct 26 '22 02:10 malinthar

Can you check the following case where we're not getting the code action Convert to 'xml' template for parameter i?

function test(xml i = `abc`) returns string {
    return string `def`;
}

Addressed this scenario.

LakshanWeerasinghe avatar Oct 26 '22 05:10 LakshanWeerasinghe

Closing this since we won't be sending this to 2201.2.x

IMS94 avatar Oct 27 '22 04:10 IMS94