ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Fix completions in qualified name reference context

Open mindula opened this issue 2 years ago • 1 comments

Purpose

This PR adds missing completions in qualified name reference context.

Fixes #36718

Samples

Screenshot 2022-08-19 at 12 56 44

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [x] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

mindula avatar Aug 19 '22 07:08 mindula

Codecov Report

Merging #37457 (7677577) into 2201.2.x (c743f3d) will increase coverage by 2.77%. The diff coverage is 85.33%.

@@              Coverage Diff               @@
##             2201.2.x   #37457      +/-   ##
==============================================
+ Coverage       71.97%   74.75%   +2.77%     
- Complexity      48336    50060    +1724     
==============================================
  Files            3334     3334              
  Lines          192888   192893       +5     
  Branches        25197    25199       +2     
==============================================
+ Hits           138838   144197    +5359     
+ Misses          46215    40374    -5841     
- Partials         7835     8322     +487     
Impacted Files Coverage Δ
...llerinalang/compiler/semantics/analyzer/Types.java 77.10% <62.50%> (ø)
...ler/api/impl/symbols/BallerinaTableTypeSymbol.java 93.87% <81.25%> (ø)
...sions/ballerina/symbol/BallerinaSymbolService.java 58.79% <88.09%> (+4.62%) :arrow_up:
...ballerina/compiler/api/impl/TypeParamResolver.java 70.44% <100.00%> (ø)
.../providers/context/ClassDefinitionNodeContext.java 80.00% <100.00%> (+0.38%) :arrow_up:
...tions/providers/context/ModulePartNodeContext.java 80.00% <100.00%> (+0.37%) :arrow_up:
.../java/io/ballerina/shell/service/ShellWrapper.java 88.60% <100.00%> (+0.29%) :arrow_up:
...a/runtime/internal/scheduling/RuntimeRegistry.java 62.26% <0.00%> (-24.53%) :arrow_down:
... and 224 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 19 '22 08:08 codecov[bot]

Decided not to show completions for the above scenario.

mindula avatar Aug 26 '22 07:08 mindula