ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Fix suggesting incorrect completions inside match clause

Open TharushiJay opened this issue 2 years ago • 1 comments

Purpose

This PR refactors the completions inside match clause to avoid suggesting incorrect completions for if clause.

Fixes #37305

Samples

Screenshot 2022-08-17 at 16 00 08

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [x] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

TharushiJay avatar Aug 17 '22 10:08 TharushiJay

Codecov Report

Merging #37427 (4481d6f) into 2201.2.x (8d68cee) will increase coverage by 0.02%. The diff coverage is 77.77%.

@@              Coverage Diff               @@
##             2201.2.x   #37427      +/-   ##
==============================================
+ Coverage       74.73%   74.75%   +0.02%     
- Complexity      50045    50057      +12     
==============================================
  Files            3335     3334       -1     
  Lines          192899   192896       -3     
  Branches        25198    25202       +4     
==============================================
+ Hits           144167   144204      +37     
+ Misses          40402    40368      -34     
+ Partials         8330     8324       -6     
Impacted Files Coverage Δ
...llerinalang/compiler/semantics/analyzer/Types.java 77.10% <62.50%> (ø)
...ions/providers/context/MatchClauseNodeContext.java 91.66% <77.77%> (-2.09%) :arrow_down:
...ler/api/impl/symbols/BallerinaTableTypeSymbol.java 93.87% <81.25%> (ø)
...ballerina/compiler/api/impl/TypeParamResolver.java 70.44% <100.00%> (ø)
...r/extensions/ballerina/symbol/ExpressionRange.java
...g/diagramutil/connector/models/connector/Type.java 38.46% <0.00%> (+0.68%) :arrow_up:
...llerina/runtime/internal/scheduling/Scheduler.java 75.91% <0.00%> (+1.45%) :arrow_up:
...allerinalang/langserver/common/utils/PathUtil.java 87.80% <0.00%> (+2.43%) :arrow_up:
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 17 '22 12:08 codecov[bot]