ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Provide missing completions in mapping constructor context

Open malinthar opened this issue 3 years ago • 1 comments

Purpose

$subject by fixing new expression visiting logic in ContextTypeResolver class.

Fixes #36339

Approach

Describe how you are implementing the solutions along with the design details.

Samples

image

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • [ ] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [ ] Added necessary tests
    • [ ] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

malinthar avatar Aug 09 '22 07:08 malinthar

Codecov Report

Merging #37312 (d880b24) into 2201.2.x (fa51577) will decrease coverage by 0.00%. The diff coverage is 78.94%.

@@              Coverage Diff               @@
##             2201.2.x   #37312      +/-   ##
==============================================
- Coverage       74.74%   74.73%   -0.01%     
- Complexity      49949    49969      +20     
==============================================
  Files            3326     3328       +2     
  Lines          192604   192671      +67     
  Branches        25142    25149       +7     
==============================================
+ Hits           143953   144000      +47     
- Misses          40358    40379      +21     
+ Partials         8293     8292       -1     
Impacted Files Coverage Δ
...ions/providers/context/LimitClauseNodeContext.java 76.92% <70.00%> (-4.33%) :arrow_down:
...ngserver/completions/util/ContextTypeResolver.java 73.33% <88.88%> (+0.39%) :arrow_up:
...a/runtime/internal/scheduling/RuntimeRegistry.java 66.03% <0.00%> (-20.76%) :arrow_down:
.../org/ballerinalang/langserver/LSPackageLoader.java 80.20% <0.00%> (-13.22%) :arrow_down:
.../compiler/bir/codegen/interop/JMethodResolver.java 78.55% <0.00%> (-0.25%) :arrow_down:
...ngserver/command/executors/PullModuleExecutor.java 2.15% <0.00%> (-0.24%) :arrow_down:
...nalang/langserver/commons/eventsync/EventKind.java 100.00% <0.00%> (ø)
...er/eventsync/subscribers/PullModuleSubscriber.java 100.00% <0.00%> (ø)
...rver/eventsync/publishers/PullModulePublisher.java 100.00% <0.00%> (ø)
...oviders/context/util/ServiceTemplateGenerator.java 80.47% <0.00%> (+0.13%) :arrow_up:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 09 '22 08:08 codecov[bot]