ballerina-lang icon indicating copy to clipboard operation
ballerina-lang copied to clipboard

Fix type resolving issue for intersection types having a type def for the same type

Open sanjana opened this issue 3 years ago • 2 comments

Purpose

$subject

Fixes #35624

Approach

Samples

Remarks

This fix only applied on the Semantic API. A profound solution would be needed once #36855 is completed.

Check List

  • [x] Read the Contributing Guide
  • [ ] Updated Change Log
  • [ ] Checked Tooling Support (#<Issue Number>)
  • [x] Added necessary tests
    • [x] Unit Tests
    • [ ] Spec Conformance Tests
    • [ ] Integration Tests
    • [ ] Ballerina By Example Tests
  • [ ] Increased Test Coverage
  • [ ] Added necessary documentation
    • [ ] API documentation
    • [ ] Module documentation in Module.md files
    • [ ] Ballerina By Examples

sanjana avatar Jul 20 '22 10:07 sanjana

Codecov Report

Merging #37080 (5c1248d) into 2201.2.x (c743f3d) will increase coverage by 2.77%. The diff coverage is 86.20%.

@@              Coverage Diff               @@
##             2201.2.x   #37080      +/-   ##
==============================================
+ Coverage       71.97%   74.75%   +2.77%     
- Complexity      48336    50060    +1724     
==============================================
  Files            3334     3334              
  Lines          192888   192903      +15     
  Branches        25197    25201       +4     
==============================================
+ Hits           138838   144211    +5373     
+ Misses          46215    40369    -5846     
- Partials         7835     8323     +488     
Impacted Files Coverage Δ
...llerinalang/compiler/semantics/analyzer/Types.java 77.10% <62.50%> (ø)
...ler/api/impl/symbols/BallerinaTableTypeSymbol.java 93.87% <81.25%> (ø)
...sions/ballerina/symbol/BallerinaSymbolService.java 58.79% <88.09%> (+4.62%) :arrow_up:
.../io/ballerina/compiler/api/impl/SymbolFactory.java 90.51% <88.88%> (-0.10%) :arrow_down:
...ballerina/compiler/api/impl/TypeParamResolver.java 70.44% <100.00%> (ø)
...ler/api/impl/symbols/BallerinaArrayTypeSymbol.java 97.22% <100.00%> (+0.25%) :arrow_up:
...impl/symbols/BallerinaTypeReferenceTypeSymbol.java 81.96% <100.00%> (+1.26%) :arrow_up:
...a/runtime/internal/scheduling/RuntimeRegistry.java 83.01% <0.00%> (-3.78%) :arrow_down:
.../ballerina/runtime/internal/scheduling/Strand.java 78.66% <0.00%> (-0.84%) :arrow_down:
... and 225 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 26 '22 08:07 codecov[bot]

Shall we re-sync with the 2201.2.x branch?

dulajdilshan avatar Aug 12 '22 06:08 dulajdilshan