ballerina-lang
ballerina-lang copied to clipboard
Change hash for tuple in TypeHashVisitor
Purpose
Fixes type name for tuples
Fixes #37038
Approach
Describe how you are implementing the solutions along with the design details.
Samples
Provide high-level details about the samples related to this feature.
Remarks
List any other known issues, related PRs, TODO items, or any other notes related to the PR.
Check List
- [ ] Read the Contributing Guide
- [ ] Updated Change Log
- [ ] Checked Tooling Support (#<Issue Number>)
- [ ] Added necessary tests
- [ ] Unit Tests
- [ ] Spec Conformance Tests
- [ ] Integration Tests
- [ ] Ballerina By Example Tests
- [ ] Increased Test Coverage
- [ ] Added necessary documentation
- [ ] API documentation
- [ ] Module documentation in Module.md files
- [ ] Ballerina By Examples
Codecov Report
Base: 77.09% // Head: 76.27% // Decreases project coverage by -0.81%
:warning:
Coverage data is based on head (
2e6cdaa
) compared to base (8ccdc06
). Patch coverage: 96.15% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #37041 +/- ##
============================================
- Coverage 77.09% 76.27% -0.82%
+ Complexity 63166 53254 -9912
============================================
Files 3397 3407 +10
Lines 235766 200796 -34970
Branches 36659 25880 -10779
============================================
- Hits 181759 153158 -28601
+ Misses 44983 39051 -5932
+ Partials 9024 8587 -437
Impacted Files | Coverage Δ | |
---|---|---|
...nalang/compiler/tree/types/BLangTupleTypeNode.java | 66.66% <ø> (ø) |
|
...ang/compiler/semantics/model/types/BArrayType.java | 97.50% <90.90%> (-2.50%) |
:arrow_down: |
...allerinalang/compiler/parser/BLangNodeBuilder.java | 94.34% <100.00%> (-1.78%) |
:arrow_down: |
...ng/compiler/semantics/analyzer/SymbolResolver.java | 84.77% <100.00%> (-1.40%) |
:arrow_down: |
...ang/compiler/semantics/model/types/BTupleType.java | 69.56% <100.00%> (-0.55%) |
:arrow_down: |
...tensions/ballerina/document/visitor/FindNodes.java | 0.00% <0.00%> (-61.12%) |
:arrow_down: |
...llerinalang/debugadapter/variable/types/BByte.java | 0.00% <0.00%> (-55.56%) |
:arrow_down: |
...rinalang/langserver/hover/HoverObjectResolver.java | 27.93% <0.00%> (-54.75%) |
:arrow_down: |
...rg/ballerinalang/testerina/core/TestProcessor.java | 33.83% <0.00%> (-53.28%) |
:arrow_down: |
...testerina/natives/mock/GenericMockObjectValue.java | 8.75% <0.00%> (-51.25%) |
:arrow_down: |
... and 912 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ushirask testAssignmentNegativeCases
seems to be failing
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale
label is removed or commented.
Closed PR due to inactivity for more than 18 days.
Closed PR due to inactivity for more than 18 days.
@ushirask can you check on the build
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale
label is removed or commented.
Closed PR due to inactivity for more than 18 days.