wifi-connect icon indicating copy to clipboard operation
wifi-connect copied to clipboard

Document required labels, and document how to apply labels

Open MattSGS opened this issue 5 years ago • 3 comments

The wifi connect container wants to talk to the host's dbus, which requires it to have the host's directory containing the host's dbus socket bind-mounted into the wifi connect container.

There's a vague and incomplete description of how to accomplish this using docker-compose metadata labels here.

This documentation should be expanded to describe how to apply these labels. Balena doesn't understand the usual docker compose syntax whereby 'build' is a dictionary, so it's important to document the syntax that balena does accept.

wifi connect's requirement for a 'io.resin.features.dbus' label should be documented in the wifi connect documentation.

Once the resin.io documentation describes how to apply labels, it should be linked to from the wifi connect documentation that describes which label(s) are required.

This example seems to partially work for me (it fails, but for reasons that I suspect are unrelated to this issue):

  wifi-connect:
    build: ./wifi-connect
    labels:
      io.resin.features.dbus: '1'
    privileged: true
    environment:
      - DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host/run/dbus/system_bus_socket
      - WIFI_CONNECT_IFACE=wlan0

MattSGS avatar Aug 22 '18 02:08 MattSGS

Please add network_mode: "host" to have it working completely. I will include such example in the README.

majorz avatar Aug 22 '18 05:08 majorz

[shaunmulligan] This issue has attached support thread https://jel.ly.fish/#/support-thread~7ee336b8-4679-477b-bbc9-1b68f38a7276

balena-ci avatar Nov 21 '19 21:11 balena-ci

I think this issue was resolved and can be closed?

crbn60 avatar Dec 13 '20 01:12 crbn60