meta-balena icon indicating copy to clipboard operation
meta-balena copied to clipboard

meta-balena-common: upgrade from go 1.16.2 to 1.17.13

Open lmbarros opened this issue 1 year ago • 2 comments

Bringing Go updates from kirkstone commit a38f831 (from https://git.openembedded.org/openembedded-core/). Go 1.17 is what Moby used in the version our current balenaEngine is based in.


Contributor checklist

  • [ ] Changes have been tested
    • [ ] Covered in automated test suite
    • [ ] Manual test case recorded
  • [ ] Change-type present on at least one commit
  • [ ] Signed-off-by is present
  • [ ] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

lmbarros avatar Mar 24 '23 13:03 lmbarros

balena-engine binary actually grew from 40MB to 45MB, in a test build I made for a Pi3-64.

lmbarros avatar Mar 24 '23 14:03 lmbarros

@lmbarros Yeah, it's unfortunate. I also tested a newer Go version and found it increased binary size.

jakogut avatar Mar 24 '23 18:03 jakogut