meta-balena icon indicating copy to clipboard operation
meta-balena copied to clipboard

Published 20 hours ago • verified publisher icon balena-os

HUP support for LUKS encrypted partitions

Open alexgg opened this issue 3 years ago • 28 comments

Contributor checklist

  • [x] Changes have been tested
    • [ ] Covered in automated test suite
    • [ ] Manual test case recorded
  • [x] Change-type present on at least one commit
  • [x] Signed-off-by is present
  • [x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

alexgg avatar Feb 16 '22 11:02 alexgg

@balena-ci rebase

mtoman avatar Mar 21 '22 14:03 mtoman

@balena-ci rebase

mtoman avatar Mar 23 '22 11:03 mtoman

@balena-ci rebase

mtoman avatar Mar 31 '22 09:03 mtoman

@balena-ci rebase

mtoman avatar Apr 08 '22 09:04 mtoman

@balena-ci rebase

mtoman avatar May 03 '22 12:05 mtoman

@balena-ci rebase

mtoman avatar May 30 '22 12:05 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 17 '22 14:06 mtoman

@balena-ci rebase

mtoman avatar Jun 18 '22 12:06 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 18 '22 19:06 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 18 '22 20:06 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 19 '22 04:06 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 19 '22 10:06 mtoman

@balena-ci rebase

mtoman avatar Jun 20 '22 04:06 mtoman

@balena-ci rebase

mtoman avatar Jun 21 '22 15:06 mtoman

@balena-ci rebase

mtoman avatar Jun 21 '22 17:06 mtoman

@resin-jenkins retest this please

mtoman avatar Jun 21 '22 19:06 mtoman

@balena-ci rebase

mtoman avatar Jul 18 '22 11:07 mtoman

@balena-ci rebase

mtoman avatar Jul 21 '22 08:07 mtoman

@resin-jenkins retest this please

mtoman avatar Jul 21 '22 09:07 mtoman

@balena-ci rebase

mtoman avatar Jul 21 '22 12:07 mtoman

@balena-ci rebase

mtoman avatar Jul 21 '22 15:07 mtoman

@balena-ci rebase

mtoman avatar Jul 24 '22 05:07 mtoman

@balena-ci rebase

mtoman avatar Jul 24 '22 20:07 mtoman

@resin-jenkins retest this please

mtoman avatar Jul 25 '22 10:07 mtoman

@mtoman this seems to be breaking on HUP

jenkins-leviathan-v2-template-3216-client-1  | [2022-07-25T12:42:02.031Z][worker-hup]             not ok 5 - Should not have rollback-health-breadcrumb in the state partition

Have you tested HUP locally?

klutchell avatar Jul 25 '22 13:07 klutchell

@klutchell yes, HUP is literally what this patch should fix but I'll double check there are no new regressions before re-running leviathan

mtoman avatar Jul 25 '22 13:07 mtoman

@balena-ci rebase

alexgg avatar Aug 24 '22 15:08 alexgg

An error occurred while processing the comment. Please contact support with your Context-ID: 6fbb9fd0-23c5-11ed-823c-7670d99183e4

ghost avatar Aug 24 '22 15:08 ghost

@resin-jenkins retest this please

mtoman avatar Nov 09 '22 19:11 mtoman

@balena-ci rebase

alexgg avatar Nov 10 '22 10:11 alexgg