balena-allwinner icon indicating copy to clipboard operation
balena-allwinner copied to clipboard

Update orangepi lite

Open mwohlert opened this issue 5 years ago • 4 comments

mwohlert avatar Oct 24 '19 04:10 mwohlert

Can one of the admins verify this patch?

resin-jenkins avatar Oct 24 '19 04:10 resin-jenkins

Hi @mwohlert,

Thanks for contributing! We already seem to have the 8189fs kernel module added for the orange pi lite in meta-balena-allwinner/recipes-kernel/linux/linux-mainline_%.bbappend :

` RESIN_CONFIGS_append_orange-pi-lite = "
8189fs
"

RESIN_CONFIGS[8189fs] ?= "
CONFIG_RTL8189FS=m
" ` Are you having troubles with that? Is there a particular reason why you want to use the out of tree kernel module?

Kind regards

vicgal avatar Nov 04 '19 15:11 vicgal

@vicgal Ah yes I see that. I suggest for that to be removed in favor of the standalone module, which I think is easier to maintain than a huge patch like the 8189 is: https://github.com/balena-os/balena-allwinner/blob/master/layers/meta-balena-allwinner/recipes-kernel/linux/linux-mainline/armbian/wifi-add-realtek-8189fs.patch

The 8189fs driver is already an out of tree module

mwohlert avatar Nov 04 '19 17:11 mwohlert

@mwohlert, Ok, I see your point, but we don't actually maintain that patch since it's coming from Armbian. We have from them the kernel and the patches that come with it. If they update the kernel/patches, we follow through. If we were to have the OOT kernel module in our yocto layer, that would make us maintainers of the yocto recipe the least.

vicgal avatar Nov 05 '19 10:11 vicgal