open-balena-api icon indicating copy to clipboard operation
open-balena-api copied to clipboard

Published 20 hours ago • verified publisher icon balena-io

Check that deviceId is defined to handle cutovers from older versions

Open dcaputo-harmoni opened this issue 1 year ago • 2 comments

fixes #1349 Change-type: patch

dcaputo-harmoni avatar May 14 '23 12:05 dcaputo-harmoni

Hi, Thanks for opening this. While we are discussing this internally, can you please amend the commit message to better communicate that this is a change about the device heartbeat feature? Maybe something along the lines of:

Skip device heartbeat RSMQ records missing a deviceId property

thgreasi avatar May 15 '23 08:05 thgreasi

Oh I should have also mentioned that we need the commit message to also include a Change-type just like you did in the PR description. Something like the following should pass the versioning test:

$ git commit --amend

Skip device heartbeat RSMQ records missing a deviceId property

Change-type: patch

thgreasi avatar May 15 '23 08:05 thgreasi