balena-sdk-python icon indicating copy to clipboard operation
balena-sdk-python copied to clipboard

SDK does not handle request exceptions

Open ejohnso49 opened this issue 5 years ago • 0 comments

When the SDK makes requests to the Balena API, it will not catch exceptions raised by the requests package. These exceptions then bubble up to the SDK client. I think it would be nice for the SDK to catch these and return something to the client to indicate the operation failed instead of not handling the exception. The instance I encountered was a call with balena.models.supervisor.reboot() resulting in a requests.exceptions.ReadTimeout.

ejohnso49 avatar Apr 26 '19 23:04 ejohnso49