balena-cli icon indicating copy to clipboard operation
balena-cli copied to clipboard

patch: dedupe on ci

Open aethernet opened this issue 1 year ago • 3 comments

run npm dd as a postinstall step

aethernet avatar Oct 08 '24 11:10 aethernet

I don't think that's a good idea, since postinstall runs on consumer's side as well See: https://docs.npmjs.com/cli/v9/using-npm/scripts

thgreasi avatar Oct 08 '24 12:10 thgreasi

@thgreasi why is that a problem?

aethernet avatar Oct 08 '24 12:10 aethernet

@aethernet for first it will slow down npm i -g balena-cli considerably, and it will also potentially update the local dependencies thus having them diverge from the ones that the shrinkwrap included.

thgreasi avatar Oct 08 '24 13:10 thgreasi