Unsupported device types appear on the `devices supported` output

Open alexgg opened this issue 3 years ago • 1 comments

Expected Behavior

Unsupported device types should not appear on the devices supported list.

Actual Behavior

As soon as work to support a device is started and there is a contract for it, the device appears in the API device endpoint and hence in the output of balena devices supported but the device type is not yet usable.

Probably a further API check to make sure there are final releases in the hostapp should be made before listing the device.

Steps to Reproduce the Problem

Right now the Radxa zero in in this state, and: balena devices supported | grep -i "radxa" radxa-zero aarch64 Radxa Zero

Specifications

balena --version 14.2.0

Aug 17 '22 12:08 alexgg

@thgreasi Can you confirm whether this is the desired behavior for devices supported and furthermore for the sdk's deviceTypes.getAllSupported method? If so then to fix this we need to update the $filter in the sdk method to only keep deviceTypes with finalized releases: https://github.com/balena-io/balena-sdk/blob/4473a25667aadd144f1bd90cc5ea72f0c9d736d3/lib/models/device-type.ts#L190

Aug 23 '22 14:08 myarmolinsky

Fixed by https://github.com/balena-io/balena-cli/pull/2607

Apr 05 '23 08:04 thgreasi