balena-cli icon indicating copy to clipboard operation
balena-cli copied to clipboard

Test balena push with docker-compose using symlinks

Open thgreasi opened this issue 4 years ago • 1 comments

Change-type: patch See: https://www.flowdock.com/app/rulemotion/i-cli/threads/Yo53CeVqtfSoo4Dw_qO8B0ZD2Nu Signed-off-by: Thodoris Greasidis [email protected]

Resolves: #
Change-type: major|minor|patch
Depends-on:
See:


Please check the CONTRIBUTING.md file for relevant information and some guidance. Keep in mind that the CLI is a cross-platform application that runs on Windows, macOS and Linux. Tests will be automatically run by balena CI on all three operating systems, but this will only help if you have added test code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be automatically copied to the CHANGELOG.md file, so try writing it in a way that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the PR, please add a PR description to explain its purpose or the features that it implements. Adding PR comments to blocks of code that aren't self explanatory usually helps with the review process.

If the PR introduces security considerations or affects the development, build or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

thgreasi avatar Dec 13 '21 18:12 thgreasi

Build failed quickly for all platforms because of missing npm run build that calls npm run lint that modifies the source code and causes uncommitted code changes:

** Uncommitted changes found (^^^ diff above ^^^) - FAIL **
Error: "catch-uncommitted": npx failed with exit code 1:

pdcastro avatar Dec 13 '21 23:12 pdcastro