balena-cli icon indicating copy to clipboard operation
balena-cli copied to clipboard

Changing the docker-compose file in a livepush session will not cause a full rebuild

Open CameronDiver opened this issue 5 years ago • 4 comments

As anything could have changed, this should cause a full rebuild to occur, without having to ctrl+c and restart the process.


Please keep in mind that we try to use the issue tracker of this repository for specific bug reports & CLI feature requests. General & troubleshooting questions are encouraged to be posted to the balena forums, which are monitored by balena's support team and where the community can both contribute and benefit from the answers.

Before submitting this issue please check that this issue is not a duplicate. If there is another issue describing the same problem or feature please add your information to the existing issue's comments.

CameronDiver avatar Jun 17 '19 15:06 CameronDiver

@pdcastro do you think it's sufficient to just restart the complete livepush session when we detect a change to the compose file? Or is there something we could do better than basically automating CTRL-C+restart?

Hades32 avatar Jan 07 '22 16:01 Hades32

@Hades32, in truth I am not familiar enough with the livepush codebase to be able tell without some deep investigation. If you are planning to fix this issue, I suppose you will familiarise yourself with it better than me. :-) The only thing I would suggest is that you have a look at how livepush current treats changes to the Dockerfile(s). And when you say "basically automating CTRL-C+restart", hopefully you don't literally mean exiting the CLI process and/or creating a CLI subprocess. :-)

cc @srlowe in case he has anything to add.

pdcastro avatar Jan 08 '22 02:01 pdcastro

haha, no no, definitely not literally doing that 😂

Hades32 avatar Jan 10 '22 15:01 Hades32

The ideal situation here is to re-run all intialisation that livepush performs for a given project when the docker-compose changes. There's no need to end the process, but re-parsing the docker-compose, all Dockerfiles etc is necessary.

CameronDiver avatar Jan 11 '22 10:01 CameronDiver