magento2-module-url-data-integrity-checker icon indicating copy to clipboard operation
magento2-module-url-data-integrity-checker copied to clipboard

git hub actions

Open DominicWatts opened this issue 3 years ago • 2 comments

docker container based github actions to test code instead of makefile which for example relies on components being available locally. Plus get added automatic code scan on any PRs

key is in action so publicly visible but no reason couldn't utilise github secrets for key

this is more a demo of what can be done

Results look like this:

https://github.com/DominicWatts/magento2-module-url-data-integrity-checker/actions

You don't have to use container approach e.g. https://github.com/DominicWatts/Menu/blob/master/.github/workflows/standards.yml

However the reason I use container based approach is it's easier to switch php version and also for phpstan in particular not to throw false positives if components from M2 required modules are used : php_intl - e.g. IntlDateFormatter not found etc.

https://github.com/DominicWatts/PHPStan

But certainly container based unit tests are difficult

DominicWatts avatar Aug 23 '21 20:08 DominicWatts