microk8s-actions icon indicating copy to clipboard operation
microk8s-actions copied to clipboard
verified publisher icon balchua

feat: wait for storage to be fully enabled

Open ca-scribner opened this issue 4 years ago • 1 comments

This fixes the case where a race condition occurs between the enabling of storage and the usage of that storage in future actions. Existing waits do not capture delays in storage enabling, so things like juju bootstrap will fail when the storage isn't yet available.

ca-scribner avatar Aug 23 '21 15:08 ca-scribner

@ca-scribner thanks for this PR, i think the right place of putting this fix is in side the function enableAddon(). The enableStorage is deprecated.

Better yet, should we have a generic wait instead? Wdyt?

balchua avatar Aug 23 '21 22:08 balchua

@ca-scribner Sorry this one took soo long. I've implemented your work into the latest version v0.3.2 Thank you for your work on this.

balchua avatar Feb 25 '23 04:02 balchua

no worries, thanks!

On Fri, Feb 24, 2023 at 23:40 balchua @.***> wrote:

Closed #7 https://github.com/balchua/microk8s-actions/pull/7.

— Reply to this email directly, view it on GitHub https://github.com/balchua/microk8s-actions/pull/7#event-8607275720, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPFPIYQDPVK7Y3I46QVKJLWZGEMLANCNFSM5CU2HEOQ . You are receiving this because you were mentioned.Message ID: @.***>

ca-scribner avatar Feb 25 '23 10:02 ca-scribner