composer-git-merge-driver icon indicating copy to clipboard operation
composer-git-merge-driver copied to clipboard

Published 20 hours ago • verified publisher icon balbuf

never link to branches; update $platformPackageRegexp from 1.8.5

Open glensc opened this issue 5 years ago • 4 comments

my standard disclaimer:

Don't link to branches!

  • see https://news.ycombinator.com/item?id=8046710 and https://help.github.com/articles/getting-permanent-links-to-files/
  • hit y
  • and perhaps https://github.com/josephfrazier/octopermalinker

glensc avatar Apr 15 '19 08:04 glensc

@balbuf ping

glensc avatar May 09 '20 08:05 glensc

@glensc looks like the regex was updated again, want to update this PR accordingly?

https://github.com/composer/composer/commit/0ab48a1773e55ee1706d43e739fa5719811a87c8#diff-577304d6b2175e0b5c3fe90ff0a78239R31

balbuf avatar Jun 22 '20 19:06 balbuf

This is part of 2.0.0-alpha, but at first blush I can't imagine there would be any BC issues. Thoughts?

balbuf avatar Jun 22 '20 19:06 balbuf

you should merge this as is. I'm not interested at this time to investigate more about the impact of updating it again.

glensc avatar Jun 25 '20 08:06 glensc