urlcat icon indicating copy to clipboard operation
urlcat copied to clipboard

Published 20 hours ago • verified publisher icon balazsbotond

Query params output

Open Saafine opened this issue 4 years ago • 10 comments

Describe the bug Possibly incorrect queryParams output

To Reproduce urlcat('https://google.com', '', {test: 'abc'}) returns https://google.com/test=abc

Expected behavior Should return https://google.com?test=abc

Saafine avatar Nov 19 '20 09:11 Saafine

Hey @balazsbotond Can I help for this?

harshilparmar avatar Nov 19 '20 09:11 harshilparmar

@Saafine thank you for the bug report.

I've successfully reproduced it using the currently published npm version and it is indeed a problem.

balazsbotond avatar Nov 19 '20 09:11 balazsbotond

@harshilparmar thanks, that would be great. I have a lot of work to do these days so I'm glad you showed up.

As a first step, we need to reproduce the bug on both 2.x and the master branch - let's see which version it affects. Can you help with this first? After that, let's discuss the results here and decide how to proceed.

balazsbotond avatar Nov 19 '20 09:11 balazsbotond

As a first step, we need to reproduce the bug on both 2.x and the master branch - let's see which version it affects. Can you help with this first? After that, let's discuss the results here and decide how to proceed.

@balazsbotond Yeah sure, I will let you know!!

harshilparmar avatar Nov 19 '20 10:11 harshilparmar

@balazsbotond brother, this issue affects in both 2.x and master. Observation : I think urlcat second param takes empty string in consideration.

harshilparmar avatar Nov 20 '20 20:11 harshilparmar

@harshilparmar thank you! I'm sorry it took this long to reply. If you still have the time, I'd be very thankful if you could work on a fix.

balazsbotond avatar Nov 30 '20 09:11 balazsbotond

@balazsbotond I am on it 👨‍💻

harshilparmar avatar Nov 30 '20 10:11 harshilparmar

@harshilparmar if you have time, could you backport the fix to the 2.x branch and send another PR against that branch? This way I could release a new patch release after merging it and the latest published version would be free of known bugs.

balazsbotond avatar Dec 11 '20 15:12 balazsbotond

@harshilparmar if you have time, could you backport the fix to the 2.x branch and send another PR against that branch? This way I could release a new patch release after merging it and the latest published version would be free of known bugs.

Sure brother 👍🏼

harshilparmar avatar Dec 11 '20 16:12 harshilparmar

@balazsbotond Can you please close this issue? It might take time for new contributors.

harshilparmar avatar Feb 08 '21 04:02 harshilparmar

Closing because I decided to delete the 2.x branch and concentrate on maintaining the currently published version.

balazsbotond avatar Nov 12 '22 00:11 balazsbotond

Closing because I decided to delete the 2.x branch and concentrate on maintaining the currently published version.

Really happy to see you back here ☺️

harshilparmar avatar Nov 12 '22 00:11 harshilparmar

@harshilparmar nice to see you again too :)

balazsbotond avatar Nov 12 '22 01:11 balazsbotond