remix-seo icon indicating copy to clipboard operation
remix-seo copied to clipboard

Support either Remix ^1.0.0 or ^2.0.0

Open lpsinger opened this issue 2 years ago • 7 comments

Remix 2.0.0 is coming out very soon --- prereleases are coming out. Allow the peer dependencies to be met by Remix v1 or v2.

lpsinger avatar Sep 03 '23 23:09 lpsinger

@balavishnuvj I recently attempted to install @balavishnuvj/remix-seo alongside the newly released Remix version 2.0.0-pre.x, but encountered a peer dependency conflict.

I'd like this PR to be merged and released to fix the issue. If there's a workaround I could use in the meantime, I'd appreciate some guidance.

tommyasai avatar Sep 06 '23 17:09 tommyasai

I think that the reason for the peer dependency conflict is that the prereleases cannot satisfy the dependency.

lpsinger avatar Sep 06 '23 20:09 lpsinger

@lpsinger Noted. I use --legacy-peer-deps as a temporary solution

tommyasai avatar Sep 08 '23 01:09 tommyasai

FYI: Upgraded to remix v2.0.0 but I am seeing the same error.

#11 4.700 npm ERR! While resolving: @balavishnuvj/[email protected]
#11 4.700 npm ERR! Found: @remix-run/[email protected]
#11 4.700 npm ERR! node_modules/@remix-run/react
#11 4.700 npm ERR!   @remix-run/react@"^2.0.0" from the root project
#11 4.700 npm ERR! 
#11 4.700 npm ERR! Could not resolve dependency:
#11 4.700 npm ERR! peer @remix-run/react@"^1.0.0" from @balavishnuvj/[email protected]
#11 4.700 npm ERR! node_modules/@balavishnuvj/remix-seo
#11 4.700 npm ERR!   @balavishnuvj/remix-seo@"^1.0.2" from the root project
#11 4.700 npm ERR! 
#11 4.700 npm ERR! Conflicting peer dependency: @remix-run/[email protected]
#11 4.700 npm ERR! node_modules/@remix-run/react
#11 4.700 npm ERR!   peer @remix-run/react@"^1.0.0" from @balavishnuvj/[email protected]

tommyasai avatar Sep 17 '23 05:09 tommyasai

:shrug: It's working for me now that Remix 2.0.0 is out. See https://github.com/nasa-gcn/gcn.nasa.gov/pull/1377.

lpsinger avatar Sep 17 '23 22:09 lpsinger

Thanks. I switched to your fork and it worked. 🙏

tommyasai avatar Sep 23 '23 03:09 tommyasai

This is fixed in our fork: https://github.com/nasa-gcn/remix-seo

lpsinger avatar Sep 23 '23 12:09 lpsinger