balanced-network-interface
balanced-network-interface copied to clipboard
Show LP fees APR in user liquidity details
Add Fees apr to the Current user supply section for the users lp
@RiseBlock
The fees APR is already available here:
we want to add the fees APR to the users incentivised APR in the liquidity section, so that they can see the actual APR they are earning, instead of just BALN incentivised APR. Basically just add the pool fees APR to the users boosted incentivised APR and rename the column to APR here:
we should also add the fees APR here:
@parrot9design can you please second all that?
Thanks @hetfly!
Yep, for the top section, let's add the fee amount to the existing APR (so if the BALN range is 0.4% - 1%
and fees are 0.87%
, we should display a range of 1.27% - 1.87%
)
For the piece in the Liquidity Pools section, let's keep the values split so people can see where their return is coming from, specifically. So:
APR BALN: x% Fees: x%
(By updating both sections from APY to APR, we'll also remove a major inconsistency between the app and Stats page.)
The PR that was merged for this did not adequately address the issue. In future, do not merge any PRs until myself or @hetfly have reviewed them.
- The BALN APR should not be a range here. It should be a specific number, based on the amount of bBALN I hold and the LP tokens I've staked.
- The APR column label needs a tooltip beside it like shown in the
Incentivised pools
list. - The tooltip message (in both places) needs to be adjusted to use
APR
instead ofAPY
, and let's cut the line about impermanent loss.
On mobile, I see an APY (should be APR) of 0.43%, which makes zero sense based on the numbers I see on desktop. As space is limited, it's fine to merge the fee APR and BALN APR into a single number.