old-balance-ios icon indicating copy to clipboard operation
old-balance-ios copied to clipboard

🔖 ENS Support

Open ricburton opened this issue 5 years ago • 2 comments

Add that before launching :)

ricburton avatar Mar 16 '19 09:03 ricburton

Looks like we can either use this Swift port of web3.js https://github.com/argentlabs/web3.swift or we can just directly use web3.js using the iOS JS bridge https://stackoverflow.com/questions/37434560/can-i-run-javascript-inside-swift-code

First one would be more native, but possibly not updated as regularly or maintained as well...

But I think I'll try it first and see if it works well, and if not, use the JS bridge.

einsteinx2 avatar Mar 22 '19 01:03 einsteinx2

Actually @wolffan pointed me to an ENS implementation based on the other web3swift framework.

Here's the example code: https://github.com/AlphaWallet/alpha-wallet-ios/blob/master/AlphaWallet/Tokens/Coordinators/GetENSOwnerCoordinator.swift

I'm going to see if I can fork the web3swift repo (https://github.com/matter-labs/web3swift), add the ENS support, and make a PR back to them rather than doing it in the app directly.

einsteinx2 avatar Mar 30 '19 16:03 einsteinx2