old-balance-ios
old-balance-ios copied to clipboard
balance-io
Use Monospace font for Address Labels
On it. Was debating whether to build an extension and change the existing ones.
See comparison of pre and post Menlo usage below.
Couple of notes:
- Menlo only has Bold and Regular for the font weight so I use Bold if medium/heavy/bold are set.
- There is no "light" option so I default to Regular.
Thoughts on changing the CDP Modal Info view numbers to the monospace font?
Totally agree @borwahs. There are lots of places where I want to use monospaced fonts and this really helps me see how to do it. Thanks!
I'll let Ben review this before merging.
Really interesting discussion here: https://stackoverflow.com/questions/38148073/uifont-monospaceddigitsystemfontofsize-not-really-monospaced
In all the designs I use SF Mono but that is actually not allowed apart from on Apple's products.
I think we need to find a monospaced font that works well for the project.
I tweeted about this before. Will look at the suggestions.
@ricburton // nice find on that SO question. I was confused why monospaced system don’t was not actually using it. Looks like the adjust font to size of container option breaks it.
Yeah it’s really annoying they don’t make it available... we snuck it into balance for Mac and they approved it but they could reject at any time so it’s better to find a different one that’s fully allowed
Also for the name of the extension swift file, I accidentally wrote UIFont-Monospaced.swift when it should be UIFont+Monospaced.swift
I did something odd here. I think I might have not branched off of develop. Not sure why there are so many conflicts. Going to look into it and repush.