balance-open icon indicating copy to clipboard operation
balance-open copied to clipboard

Add a timeout option for logging back in

Open ricburton opened this issue 8 years ago • 9 comments

I love TouchID but I don’t like touching it every time I tap on Balance.

It’d be nice if there was a way to set a timeout in minutes.

Here’s how 1Password does it:

ricburton avatar Jun 16 '17 20:06 ricburton

I would love to bump this one up to the top. Is this going to be included in the merge @einsteinx2?

ricburton avatar Aug 30 '17 13:08 ricburton

@einsteinx2 can this be added as part of the merge of Balance and Balance Open?

ricburton avatar Sep 10 '17 23:09 ricburton

Not part of the merge specifically, as we already had all the same lock UI in Balance Open. However, we can (and should) definitely add this for 1.0. It won't be much more than a few lines in the lock logic and a small prefs UI change.

einsteinx2 avatar Sep 13 '17 21:09 einsteinx2

Sorry I took so long on this. Taking a look now.

einsteinx2 avatar Dec 22 '17 03:12 einsteinx2

Got the basics of it coded, but there are a few edge cases:

  1. If we use a timer to lock, the timer will pause if the screen sleeps. The user would expect even if they have lock on sleep off, if the lock delay passes it should lock.

  2. The UI code needs to be rearchitected to support the data model locking after a delay in the background

  3. The UI code needs to be rearchitected to differentiate between immediate locking and delayed locking

I'm tentatively leaving this in 1.0 for now, but we may need to bump to 1.0.1. Lots of ways to mess this up and it's important that we do it correctly and thoroughly.

einsteinx2 avatar Dec 22 '17 04:12 einsteinx2

My changes so far are in the branch enhancement/lock-timeout

einsteinx2 avatar Dec 22 '17 04:12 einsteinx2

Taking another look at this now to see if it's doable for 1.0, otherwise I'll bump it to 1.0.1

einsteinx2 avatar Dec 22 '17 17:12 einsteinx2

Yeah this is going to have to be bumped to 1.0.1, it's a much deeper change than I initially thought and will need a lot of validation.

einsteinx2 avatar Dec 22 '17 20:12 einsteinx2

Moving this into the backlog, we don't need this for 1.0

einsteinx2 avatar Feb 01 '18 17:02 einsteinx2