balance-manager
balance-manager copied to clipboard
balance-io
🔙 Add a [Back to balance.io] button
@ricburton -- I've got a branch I'd like to submit for this. It appears I don't have permission to do so...
You can make a pull request :) On 31 Jul 2018, 18:51 -0400, David Salgado [email protected], wrote:
@ricburton -- I've got a branch I'd like to submit for this. It appears I don't have permission to do so... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Hi David,
I think you are trying to push to our branch. You should be pushing to yours.
Does that make more sense? :) On 1 Aug 2018, 22:42 -0400, David Salgado [email protected], wrote:
Looks like I'm still lacking some permissions. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Not quite, haha. So I cloned the latest branch and then branched off of it. My branch is, backButton, which I have locally. I was then going to push my branch to origin (the github repo) and create a PR against the latest branch.
This is the workflow I have always used when using github. I definitely wouldn't call myself a git expert so I might be missing something :)
@TrustyTexan does it work if you fork the repo and then make a pull request?
@ricburton How would this work in a mobile view?
I am not sure having this button is the best idea because when would a user want to go back to the landing page. I imagine balance manager having a standalone electron application in the future and it wouldn't make sense in that context either.
Thanks for tryin David. Can you explain the problems you are having making the contribution? I found it tricky to begin with too.
Pierrick has been working on making all of Manager responsive.
We have no plans for an electron app. We tried making macOS software in the early days. We find it’s just not something normal people really use a lot.
Richard On 24 Aug 2018, 06:03 +0400, Andrew Lee [email protected], wrote:
@TrustyTexan does it work if you fork the repo and then make a pull request? @ricburton How would this work in a mobile view? I am not sure having this button is the best idea because when would a user want to go back to the landing page. I imagine balance manager having a standalone electron application in the future and it wouldn't make sense in that context either. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@ricburton -- When I attempt to create a PR, I need to select the branch against which to compare the latest branch. The the workflow I'm familiar with requires me to push my local branch to origin (the github repo), so that I can select my branch when creating the PR. I just need the ability/permission to push my local branch to the github repo, so a PR can be created on the github repo comparing my branch (which needs to be pushed to the github repo) to the latest branch. I am almost positive this is a permission issue on your github repo.
My branch has code that handles responsiveness as follows:
Help me help you :)
Btw, I was on vacation camping in the mountains of Colorado. I just saw this message yesterday.
@jinchung can you give David some advice here?
Richard
On Thu, Aug 30, 2018 at 5:48 PM, David Salgado < [email protected] > wrote:
Btw, I was on vacation camping in the mountains of Colorado. I just saw this message yesterday.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/balance-io/balance-manager/issues/363#issuecomment-417325747 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAavkPo9FhIDDJgY_TVBXAM1_YFMo6VFks5uV-0jgaJpZM4Vb7zu ).
@ricburton @jinchung -- I figured out the issue. Given that this is the first OSS contribution I've made, I have not needed to fork a repo in the past. I instead cloned your repo, but I should have forked. I'll go through that process when I get some time. I'm sorry for the confusion!