balance-manager
balance-manager copied to clipboard
balance-io
🖲 Send all tokens of value
It would be cool to generate a bunch of transactions in sequence when you want to empty and ETH wallet out. There’s hundreds of clicks involved if you want to move all tokens from a software wallet to a hardware wallet.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 0.1 ETH (71.88 USD @ $718.81/ETH) attached to it.
- If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $6,802.62 more funded OSS Work available on the Gitcoin Issue Explorer
How would this work? How does balance-manager obtain the addresses for the new wallet and why would it need different transactions? For privacy (one for each address instead of a single one with all addresses)? If this is the reason, I assume the destinations would be separate addresses from the hardware wallet as well.
Ahhh, sorry I didn't understand. Ok I get it now. Should be feasible, I'll think about tackling this one. Thanks!
It was my poor explanation!
On Mon, 14 May 2018 at 12:56, Dani Guardiola [email protected] wrote:
Ahhh, sorry I didn't understand. Ok I get it now. Should be feasible, I'll think about tackling this one. Thanks!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/balance-io/balance-manager/issues/189#issuecomment-388888162, or mute the thread https://github.com/notifications/unsubscribe-auth/AAavkLfil_sOwQRHnM8AcOY1qBKXmsKtks5tybdNgaJpZM4T8w9q .
-- Richard
@DaniGuardiola Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
- [x] warning (3 days)
- [ ] escalation to mods (6 days)
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
@DaniGuardiola Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
- [x] warning (3 days)
- [ ] escalation to mods (6 days)
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days
Thanks Dani 🤗
On 25 May 2018, 08:26 -0400, Dani Guardiola [email protected], wrote:
Yes gimme some time bot — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@DaniGuardiola Snoozed Gitcoin Bot for 10 days, it can get overzealous at times. Thanks for your comments back 🚢
Why was I removed from this issue (as well as the other one)? I finally have time this week, but I've been removed in gitcoin. What is the issue?
So sorry David we need to get better at communicating the speed we like to move. For paid issues, we do not have time to wait around. We need to partner with people who are incredibly fast and available.
That makes sense.
I would advise setting shorter deadlines in Gitcoin then. One of the main reasons I picked these two issues was that the deadlines where generous, which is a requirement as I'm quite (and unpredictably) busy with my main project, some events, trips, etc.
From now on I will make sure to pick up issues from this project only when I can block time to finish it promptly. Sorry if I misunderstood your intentions.
@DaniGuardiola Absolutely.
We are still learning about @gitcoinbot and open source development in general.
If you have any other feedback, please do let me know :)
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 7Â months ago. Please review their action plans below:
1) michelgotta has started work.
Will provide a toggle / link in the send modal to send all tokens Edit the view of the modal on the "Send all tokens" state Will test this for metamask @ricburton will provide testing for hardware wallet
Learn more on the Gitcoin Issue Details page.
Work started on this branch https://github.com/michelgotta/balance-manager/tree/send-all-tokens-of-value
🔥💯🤜🤛 On 11 Jun 2018, 22:03 -0400, Michel Gotta [email protected], wrote:
Work started on this branch https://github.com/michelgotta/balance-manager/tree/send-all-tokens-of-value — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@ricburton Things I need to clarify:
- ETH should be transferred, too. ETH should be the last transfer because we need the ETH to pay for the transfers.
- User can preselect one transaction speed (gas) for all transactions. Assumed transaction price is summed up on the bottom of the modal
- Main target is, wallet should be completely empty after all transactions went through
Great questions. I hadn’t thought about this. Need to ponder.
What do you think makes sense?
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work for 0.1 ETH (49.52 USD @ $495.17/ETH) has been submitted by:
@ricburton please take a look at the submitted work:
- PR by @michelgotta
- Learn more on the Gitcoin Issue Details page
- Questions? Checkout Gitcoin Help or the Gitcoin Slack $25,600.74 more funded OSS Work available on the Gitcoin Issue Explorer
@ricburton what if instead of being in the send modal, this feature was in settings and was labeled / described more as exporting your wallet balances?
@mikedemarais can you please describe in detail where these settings are
At this time there is only one pattern on the interface to transfer coins. Initial description: generate a bunch of transaction for all tokens with transferring max amount to save hundreds of clicks.
Hey @ricburton , Gitcoin here checking in to see if @michelgotta needs to add any more improvements or edits before it can be closed and paid out?
@CPSTL Thanks for pushing this up. Would be nice if this bounty would be paid because these where a few hours of development – but I think this whole repo is out of development since a few month. A lot of development was going on when opening the PR and merging wasn't that easy (See comment by @ricburton: https://github.com/balance-io/balance-manager/pull/299#issuecomment-402983375).
@mikedemarais @DaniGuardiola Is there any activity on this repo?
Oh sorry about this. I need to dive into a Gitcoin again. Will look today.
Richard On 12 Feb 2019, 09:00 -0500, Dani Guardiola [email protected], wrote:
@michelgotta I have no idea, sorry — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.