Kevin Gibbons

Results 638 comments of Kevin Gibbons

First option sounds right to me. I wouldn't worry too much about the case where the value of an object's `[Symbol.iterator]` field changes over time - that's a very strange...

> `takeUntil()` is about taking some values from the sequence, until some condition is met. The keyword there is _take_, and it's "spatial" (i.e., it's about the sequence in the...

Yeah, I agree that the `wait` and `take` parts are quite different. But the `until` parts does feel pretty similar: "this service worker should live until some other thing comes...

That `RangeError` is standard (step 7.b.ii.1), but is unreachable without providing 2**53 inputs (since each input can increment the overflow by at most one), which is impractical to test. (Strictly...

I removed the "awaiting author" label because there's no outstanding feedback for me afaik.

> I haven't looked at whether it covers every item in the testing plan https://github.com/tc39/test262/issues/4054, but in general I don't think that should block PRs from landing. It definitely doesn't,...

This looks like a good amount of detail for a testing plan to me, but I agree that many of the tests are past the point of diminishing returns. In...

I've tried to make such plans in e.g. https://github.com/tc39/test262/issues/3738 and https://github.com/tc39/test262/issues/3828 and having concrete guidance would be great. Regarding the stage process, we could certainly have it called out as...