st-flexipatch icon indicating copy to clipboard operation
st-flexipatch copied to clipboard

[Suggestion] Use different patch for Xresources

Open Rentib opened this issue 1 year ago • 2 comments

Is there any particular reason why not use this patch for both xresources and reloading it? If not I could quickly patch the thing and add this one. I think it's much simpler than the one being used right now.

Rentib avatar Mar 04 '24 00:03 Rentib

Is there any particular reason why one would want to use the xresources-with-reload-signal patch?

I mean, does it bring anything new to the table?

Code wise it has everything hardcoded in the xrdb_load function and using macros to generate a bunch of repetitive code is not necessarily the most brilliant of engineering solutions, but all of it seems to be isolated so it wouldn't be out of the question to add this option alongside the other.

bakkeby avatar Mar 04 '24 21:03 bakkeby

I haven't noticed any performance differences. It is just that the patch seems a bit simpler. I can agree that the macros aren't the best solution though.

Rentib avatar Mar 05 '24 21:03 Rentib