streams-bootstrap icon indicating copy to clipboard operation
streams-bootstrap copied to clipboard

Add --unique-app-id parameter

Open philipp94831 opened this issue 1 year ago • 4 comments

philipp94831 avatar Jan 26 '24 08:01 philipp94831

@raminqaf @philipp94831 Like I said above, I'd prefer using a separate argument for the app id and not reusing the autoscaling one. See https://github.com/bakdata/streams-bootstrap/compare/feature/application-id-param...feature/helm-app-id for how I imagine it could work

torbsto avatar Feb 20 '24 05:02 torbsto

@raminqaf @philipp94831 Like I said above, I'd prefer using a separate argument for the app id and not reusing the autoscaling one. See feature/application-id-param...feature/helm-app-id for how I imagine it could work

I feel like having two parameters is more confusing. Then we should document it well and probably deprecat the old way of configuring it

philipp94831 avatar Feb 22 '24 15:02 philipp94831

I would be fine with deprecating it, but I'm not sure if there might be a situation in which someone wants to use KEDA but not set the consumer group via Helm. I also added this check so that we fail as early as possible: https://github.com/bakdata/streams-bootstrap/blob/b86810e10570613f8ebcd2064b390b8e8c2920d6/charts/streams-app/templates/scaled-object.yaml#L2-L4

But I agree that we should also document it properly in the values.yaml and README.md

torbsto avatar Feb 22 '24 16:02 torbsto

@raminqaf @philipp94831 Like I said above, I'd prefer using a separate argument for the app id and not reusing the autoscaling one. See feature/application-id-param...feature/helm-app-id for how I imagine it could work

There is also this annotation we should not forget about https://github.com/bakdata/streams-bootstrap/blob/master/charts/streams-app/templates/deployment.yaml#L20

philipp94831 avatar Mar 05 '24 18:03 philipp94831