Kauê Hunnicutt Bazilli
Kauê Hunnicutt Bazilli
I now use `#[derive(Serialize)]` for `QueryMatch` (and use it in `QueryResolutionLine`), and I migrated the integration tests to new interface (and to actually be an integration test in the `tests/scryer_lib`...
Ok, so with that I think this is ready to merge @mthom.
Notice that #2475 was merged and already changed the serialization for many queries simply by representing them correctly (differentiating integers and floats for example), that's why I `#[ignore]`d the integration...
> (this currently comes back as {'X': {'variable': '_A'}}) This is _correct_! `clpz:(X in 1..5)` is a residual goal which is out of scope for this. In the way I...
> Would there ever be a type other than "compound" in internally tagged? 🤔 Because the hashmap by itself would signify compound. How would you differentiate atom from string? How...
> It is often just a double precision float (without NaN and ±∞) so there is no universal way to distinguish between integer and float. Maybe this means that we...
> on the other hand if we represent anything as a string besides a string, we have to bag and tag it Yeah, that would mean integers would _always_ be...
> I would rather expect the return type to be a tagged union or pointer to a tagged union, so no need for an extra method to get the type....
I can reproduce this. Doesn't seem that hard to fix, but I also think that the whole interface may benefit from a DCG overhaul and delegation of IO to the...
> [...] so perhaps it would make more sense to factor out the commonality in an auxiliary function than then reuse it between `run_query_generator()` and `run_query()`. I think `run_query()` should...