acode-plugin-acodex
acode-plugin-acodex copied to clipboard
bajrangCoder
FEATURE REQUEST: Nerd Font Icon compatibility
Currently, nerd font icons show up as boxes instead of the correct icon
How to reproduce:
- make acodeX-server open a zsh shell instead of bash (.acodex-server/index.js, change "bash" to "zsh")
- install oh-my-zsh
- install Powerlevel10k theme
- restart termux or reload shell
- enable icons in p10k configuration
- open terminal in Acode
- icons will show as boxes
Sorry if this isn't the right place to report this, I'm just not sure if this is an AcodeX limitation or an Acode limitation but I figured I'd start with the plugin and report to Acode if it's not a plugin specific issue
I have found a way to achieve it: by loading the required font by the theme. Soon, I will provide an option to do so.
Great work! Although for some reason it doesn't preserve on save for some reason. It keeps reverting to Sapphire and erasing settings no matter what theme I choose.
Ok, Got it! Soon it will be patched.
Also make sure to review AcodeX on acode plugin store
I don't get what's going on.
If I set the font, it works for that session but as soon as I close the app and reopen it, it's back to the previous font.
How to reproduce:
In termux: cd (ensure in home directory) mkdir GitHub cd GitHub mkdir Backup cd Backup wget https://github.com/ryanoasis/nerd-fonts/releases/download/v3.0.2/FiraCode.zip (Extract zip) touch FiraCode.css (replicate FiraCode.css found here: https://github.com/GR3YH4TT3R93/dotfiles/tree/main/GitHub/Backup/FiraCode.css)
In Acode: Open terminal (ensure icons aren't working) Close terminal Open settings >> plugins >> AcodeX >> settings Select Custom Font Style Sheet >> FiraCode.css Clear Font Family Add 'Fira Code' (with single quotes) Open terminal (ensure icons are working) Close app Open app Open terminal No icons again, settings reverted to original
Where am I going wrong?
And I'm sorry if this isn't the place and you'd like me to open another issue, but logo-ls icons still don't work
Sorry for inconvenience! It's because i haven't published the patched version but Now update your AcodeX and try it.
If there is any issue let me know
Much better! It's now remembering font across restarts but logo-ls still doesn't work for some reason. The icons work correctly in termux so sadly,I don't think it's a font specific issue.
Thanks for the fast turnaround on the fix though! Awesome work as usual!
Much better! It's now remembering font across restarts but logo-ls still doesn't work for some reason. The icons work correctly in termux so sadly,I don't think it's a font specific issue.
Thanks for the fast turnaround on the fix though! Awesome work as usual!
Don't be sad! It can be fix. I have seen your custom font css file (https://github.com/GR3YH4TT3R93/dotfiles/blob/main/GitHub/Backup/FiraCode.css) there are some issues:
- you have given same name to all font, give it like that : FiraCode Regular etc.. according it's corresponding font file and
- in AcodeX font family Settings provide all font names without Single inverted comma as well as also separate your all font with Comma so AcodeX will load all. For eg: FiraCode Light, FiraCode Regular , and so on..
Restart Acode after setting custom font family
It will definitely work because I also tried it Here is my custom font css file: https://dpaste.org/DMQn7
And in my AcodeX > Settings>Font Family, I have written: MesloLGS NF Regular, MesloLGS NF Bold, MesloLGS NF Italic, MesloLGS NF Bold Italic
Note: Also makes sure to all font file , provided my theme.
Icons in the command prompt were/are working even with my bad config but logo-ls icons still don't work even with the config you provided.
How to reproduce: apt install logo-ls logo-ls logo-ls -lah .
Ok , I haven't tested! Let me test it.
Edit:
It's working for me (because i have loaded nerd font)
See 👇
It's not working on your device because you have loaded simple fira code font which doesn't contains icon , and you will need icon here. So you will need to load any font from here (you can download fira code nerd icon ) https://github.com/ryanoasis/nerd-fonts#patched-fonts
I know for a fact I'm using nerd fonts... Source: https://github.com/ryanoasis/nerd-fonts/releases/download/v3.0.2/FiraCode.zip found here: https://www.nerdfonts.com/font-downloads
Using your config with meslo and meslo fonts sourced from Powerlevel10k recommended source: https://github.com/romkatv/powerlevel10k/blob/master/font.md
is your font file and custom css file is in same folder? and have given names of loaded custom font file in acodex font family settings?
Ok , I haven't tested! Let me test it.
Edit: It's working for me (because i have loaded nerd font) See 👇
It's not working on your device because you have loaded simple fira code font which doesn't contains icon , and you will need icon here. So you will need to load any font from here (you can download fira code nerd icon ) https://github.com/ryanoasis/nerd-fonts#patched-fonts
like this
FiraCode css file my zsh icon not show
FiraCode nerd font file is built in inside AcodeX , just select them from Acodex settings> Font Family
Ok , I haven't tested! Let me test it. Edit: It's working for me (because i have loaded nerd font) See 👇
It's not working on your device because you have loaded simple fira code font which doesn't contains icon , and you will need icon here. So you will need to load any font from here (you can download fira code nerd icon ) https://github.com/ryanoasis/nerd-fonts#patched-fonts
like this
Check out this: https://github.com/bajrangCoder/acode-plugin-acodex?tab=readme-ov-file#custom-fonts
I guess that's because FiraCode nerd font doesn't contains that icons, try Meslo font from Acodex settings (As meslo have a lots of nerd icon, hopefully that will work)