shouldideploy icon indicating copy to clipboard operation
shouldideploy copied to clipboard

Feature request: Add GIFs for more fun

Open HarshaVardhanNakkina opened this issue 3 years ago • 6 comments

@baires Display a funny gifs/images below the reasons, to add more fun

HarshaVardhanNakkina avatar May 25 '21 12:05 HarshaVardhanNakkina

It could be fun, at some point I was looking into integrate with tenor api to get relevant gif for reason. Feel free to open a PR with your ideas or Discussions to brainstorming

baires avatar May 25 '21 12:05 baires

sending the whole reason as a tag/keyword to the gif API is not resulting in a relevant gif I think maitaining a list of tags/keywords along with the reasons would be a good idea what do you think?

HarshaVardhanNakkina avatar May 30 '21 11:05 HarshaVardhanNakkina

That would be nice.

I didn't know about this Tenor service, we usually use https://giphy.com/ at work. Not sure which one would provide a better API/embed options

As for how to select the GIF, I would say it would be better for each reason to have a list of GIFs URLs and then we could randomly select one of them before returning.

I like the idea of having the tags/keywords but the problem is the result could be too random, tomorrow someone uploads a GIF that has nothing to do with what we want, with one of our keywords and suddenly we are displaying it.

As the reasons are hardcoded, maybe the GIFs for each of them could also be.

Brunomachadob avatar Jun 14 '21 13:06 Brunomachadob

I like the idea of having the tags/keywords but the problem is the result could be too random, tomorrow someone uploads a GIF that has nothing to do with what we want, with one of our keywords and suddenly we are displaying it.

As the reasons are hardcoded, maybe the GIFs for each of them could also be.

perfect

HarshaVardhanNakkina avatar Jun 15 '21 11:06 HarshaVardhanNakkina

we can have URLs of selected gifs along with each reason, and randomly select one of them when displaying the corresponding reason

HarshaVardhanNakkina avatar Jun 15 '21 11:06 HarshaVardhanNakkina

I just opened pull request for this #526

HarshaVardhanNakkina avatar Jul 17 '21 06:07 HarshaVardhanNakkina