Bailey Harrington

Results 114 comments of Bailey Harrington

Even with the custom exception class, the fact that I am handling the error means `pytest` does not recognise it as thrown if the test is called from the top...

@widdowquinn Do you find the current state of testing for these changes sufficient, or would you want to see something else?

Perhaps the branch name should include 'dev' in it? I know this then means the branch name might have to be effectively changed later, but it may pre-empt some additional...

That last comment got buried in notifications.... I don't see a great number of branches (some active ones—mostly mine—and a few stale ones). Which would you be trying to eliminate?...

The current README has this table of contents: ## Table of Contents - [`pyani`](#pyani) - [Contributing](#contributing) - [Contributors ✨ (emoji key):](#contributors---emoji-key) - [Citing `pyani`](#citing-pyani) - [Table of Contents](#table-of-contents) - [Overview](#overview)...

This PR is still missing tests for the `--dry-run` option and some investigation is needed to ensure it works as expected in a non-development environment (where `pyani versiondb` would not...

In the interest of having the database migration functionality merged sooner, I would suggest that tests for the `--dry-run` option here be made a separate issue. The `--dry-run` option is...

Sorry, I missed there were comments on this the other day; I only saw the email about `codecov`.

Where is the best place for such an error to be thrown so that it is helpful for the user? Looking at the Issues you cite, both `anim.py` and `graphics.py`...

I think adding logs to the database is a really good idea; it is a good way of keeping them associated with a particular run without needing to keep a...