Baier D.
Baier D.
Thank you both! > This is a rather big API change. This might cause some more changes in CPAchecker than done in https://gitlab.com/sosy-lab/software/cpachecker/-/merge_requests/234 (which is still open and unmerged). I...
> No, I would keep it easy. Just remove the exceptions declarations (transitively) from those places where the Java compiler does not require them (just classes, don't change the public...
> What is the actual effect of this MR (supposed to be)? Is it purely an API improvement that adds new methods and deprecates some old ones, or does it...
@PhilippWendler we could deprecate the method `fromString()` and add a new method `fromSMTLIBString()`. This would reduce confusion about the change.
> > we could deprecate the method `fromString()` and add a new method `fromSMTLIBString()`. This would reduce confusion about the change. > > Would you then leave both `toString()` and...
> too many open questions. > > The whole PR never ever mentions once that the SMTLIB definition could be found online: https://smt-lib.org/theories-FloatingPoint.shtml Sorry :sweat_smile:, i assumed you guys know....
> > Just for clarification: we're returning 23 because we don't include the hidden bit in the significand size. Here _hidden bit_ refers to the first digit of the significand,...
> too many open questions. > > The whole PR never ever mentions once that the SMTLIB definition could be found online: https://smt-lib.org/theories-FloatingPoint.shtml I updated the PR text with all...
> > > And for `getTotalSize()` we might need to rediscuss the name. > > > > > > The total size is easier in my opinion, as the total...
> > Still, i would argue that we need to rename `getTotalSize()` because of this? > > If all other methods that do not include the hidden bit are called...