starlight icon indicating copy to clipboard operation
starlight copied to clipboard

The logging messages is too verbose when starting or shutting down.

Open jovany-wang opened this issue 5 years ago • 4 comments

The following logging messages is too verbose. I just did start a server and then did shutdown it.

2019-08-18 14:33:23,504 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:1 success
2019-08-18 14:33:23,807 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:29 success
2019-08-18 14:33:23,823 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:4 success
2019-08-18 14:33:23,848 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:3 success
2019-08-18 14:33:23,852 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:31 success
2019-08-18 14:33:23,853 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:28 success
2019-08-18 14:33:23,854 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:32 success
2019-08-18 14:33:23,855 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:33 success
2019-08-18 14:33:23,856 [main] INFO  com.baidu.brpc.protocol.ProtocolManager - register protocol:30 success
2019-08-18 14:33:23,859 [main] INFO  com.baidu.brpc.client.loadbalance.LoadBalanceManager - register load balance factory:RandomLoadBalanceFactory success
2019-08-18 14:33:23,860 [main] INFO  com.baidu.brpc.client.loadbalance.LoadBalanceManager - register load balance factory:RoundRobinLoadBalanceFactory success
2019-08-18 14:33:23,861 [main] INFO  com.baidu.brpc.client.loadbalance.LoadBalanceManager - register load balance factory:WeightLoadBalanceFactory success
2019-08-18 14:33:23,862 [main] INFO  com.baidu.brpc.client.loadbalance.LoadBalanceManager - register load balance factory:FairLoadBalanceFactory success
2019-08-18 14:33:23,870 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-work-thread-1
2019-08-18 14:33:23,872 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-work-thread-2
2019-08-18 14:33:23,872 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-work-thread-3
2019-08-18 14:33:23,872 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-work-thread-4
2019-08-18 14:33:23,949 [main] INFO  com.baidu.brpc.server.RpcServer - use jdk nio event mode
2019-08-18 14:33:24,031 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:timeout-timer-thread-1
2019-08-18 14:33:24,093 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstStringService, methodName=strPut
2019-08-18 14:33:24,102 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstStringService, methodName=strGet
2019-08-18 14:33:24,111 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstSetService, methodName=setPut
2019-08-18 14:33:24,114 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstSetService, methodName=setGet
2019-08-18 14:33:24,121 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstListService, methodName=listPut
2019-08-18 14:33:24,137 [main] INFO  com.baidu.brpc.server.ServiceManager - register service, serviceName=DstListService, methodName=listGet
2019-08-18 14:33:24,293 [main] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-acceptor-thread-1
2019-08-18 14:33:24,314 [main] INFO  com.baidu.brpc.server.RpcServer - server started on port=10011 success
2019-08-18 14:33:25,905 [Thread-0] INFO  com.baidu.brpc.thread.ShutDownManager - Brpc do clean work...
2019-08-18 14:33:28,012 [Thread-1] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-io-thread-1
2019-08-18 14:33:28,013 [Thread-1] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-io-thread-2
2019-08-18 14:33:28,013 [Thread-1] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-io-thread-3
2019-08-18 14:33:28,013 [Thread-1] INFO  com.baidu.brpc.utils.CustomThreadFactory - create thread:server-io-thread-4

What I suggest is only to show a starting logging message with address info in INFO level when starting like:

Succeeded to start rpc server on 127.0.0.1:10001.

Other logging messages should be debug level.

jovany-wang avatar Aug 18 '19 06:08 jovany-wang

If you guys think it's appropriate to do this, I'd like to request a PR to refine it.

@wenweihu86 cc

jovany-wang avatar Aug 18 '19 06:08 jovany-wang

@jovany-wang I think it's OK, please help fix it, thanks!

wenweihu86 avatar Aug 19 '19 01:08 wenweihu86

@MrKingHH cc

jovany-wang avatar Aug 19 '19 02:08 jovany-wang

Fine. I will do it.

MrKingHH avatar Aug 19 '19 02:08 MrKingHH